Jackie-Jiang commented on a change in pull request #4440: Fix the potential
resource leak from NettyServer
URL: https://github.com/apache/incubator-pinot/pull/4440#discussion_r304589529
##########
File path:
pinot-transport/src/test/java/org/apache/pinot/transport/perf/ScatterGatherPerfServer.java
##########
@@ -152,17 +150,15 @@ public MyRequestHandler(String response, CountDownLatch
responseHandlingLatch, l
}
@Override
- public ListenableFuture<byte[]> processRequest(ChannelHandlerContext
channelHandlerContext, ByteBuf request) {
- byte[] b = new byte[request.readableBytes()];
- request.readBytes(b);
+ public ListenableFuture<byte[]> processRequest(byte[] request) {
if (null != _responseHandlingLatch) {
try {
_responseHandlingLatch.await();
} catch (InterruptedException e) {
e.printStackTrace();
Review comment:
Good point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
