akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305007669
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java ########## @@ -108,8 +110,9 @@ private final DetectionConfigManager configDAO; private final EvaluationManager evaluationDAO; private final TaskManager taskDAO; - private final DetectionAlertConfigManager detectionAlertConfigDAO; + private final DetectionConfigFormatter detectionConfigFormatter; + private final DetectionAlertConfigFormatter detectionAlertConfigFormatter; Review comment: Shall we use detectionConfig and subscriptionConfig as a convention? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
