npawar commented on a change in pull request #4445: Refactor pinot-connectors
to break the dependencies from kafka 0.9
URL: https://github.com/apache/incubator-pinot/pull/4445#discussion_r305462463
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StreamAvroIntoKafkaCommand.java
##########
@@ -104,8 +102,12 @@ public boolean execute()
properties.put("serializer.class", "kafka.serializer.DefaultEncoder");
properties.put("request.required.acks", "1");
- ProducerConfig producerConfig = new ProducerConfig(properties);
- Producer<byte[], byte[]> producer = new Producer<byte[],
byte[]>(producerConfig);
+ StreamDataProducer streamDataProducer;
+ try {
+ streamDataProducer =
StreamDataProvider.getStreamDataProducer(KafkaStarterUtils.KAFKA_09_PRODUCER_CLASS_NAME,
properties);
Review comment:
why keep `09` in the name? I thought these same files are going to be able
to handle other versions as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
