mayankshriv commented on a change in pull request #4453: Issue #4450: Support
parsing of `Order By` (with group-by) clause in PQL compiler.
URL: https://github.com/apache/incubator-pinot/pull/4453#discussion_r305587031
##########
File path: pinot-common/src/thrift/request.thrift
##########
@@ -154,6 +154,7 @@ struct BrokerRequest {
15: optional HavingFilterQuery havingFilterQuery;
16: optional HavingFilterQueryMap havingFilterSubQueryMap;
17: optional query.PinotQuery pinotQuery;
+ 18: optional list<SelectionSort> orderBy;
Review comment:
Yes, I thought about that as well. It might cause backward compatibility
issues. Given that we are going to move to PinotQuery and drop BrokerReuqest
this won't be an issue for long, so I decided it leave it as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
