xiaohui-sun commented on a change in pull request #4465: [TE] logs and
precondition checks for pipeline re-tuning
URL: https://github.com/apache/incubator-pinot/pull/4465#discussion_r306577957
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
##########
@@ -138,8 +137,12 @@ public DetectionPipelineTaskRunner() {
this.evaluationDAO.save(evaluationDTO);
}
- // run maintenance flow to update model
- config = maintenanceFlow.maintain(config, Instant.now());
+ try {
+ // run maintenance flow to update model
+ config = maintenanceFlow.maintain(config, Instant.now());
+ } catch (Exception e) {
+ LOG.warn("Re-tune pipeline {} failed", config.getId(), e);
Review comment:
Let's add a counter here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
