Jackie-Jiang commented on a change in pull request #4392: Allow customized
metrics prefix in pinot controller/broker/server
URL: https://github.com/apache/incubator-pinot/pull/4392#discussion_r306586573
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMetrics.java
##########
@@ -26,17 +26,25 @@
*
*/
public class BrokerMetrics extends AbstractMetrics<BrokerQueryPhase,
BrokerMeter, BrokerGauge, BrokerTimer> {
+
+ public static final String METRICS_PREFIX_DEFAULT = "pinot.broker.";
Review comment:
Can you add these constants into CommonConstants? Rename to
DEFAULT_METRICS_PREFIX and DEFAULT_GLOBAL. Same for other classes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
