snleee commented on a change in pull request #4446: Add support in the
rebalancer for the user to provide minimum number of serving replicas
URL: https://github.com/apache/incubator-pinot/pull/4446#discussion_r306956681
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
##########
@@ -472,7 +472,8 @@ public String rebalance(
@ApiParam(value = "offline|realtime") @Nonnull @QueryParam("type")
String tableType,
@ApiParam(value = "true|false") @Nonnull @DefaultValue("true")
@QueryParam("dryrun") Boolean dryRun,
@ApiParam(value = "true|false") @DefaultValue("false")
@QueryParam("includeConsuming") Boolean includeConsuming,
- @ApiParam(value = "true|false") @DefaultValue("false")
@QueryParam("downtime") Boolean downtime) {
+ @ApiParam(value = "true|false") @DefaultValue("false")
@QueryParam("downtime") Boolean downtime,
+ @ApiParam(value = "1|2|3|4") @DefaultValue("1")
@QueryParam("minReplicasToKeepUpForNoDowntime") Integer minReplicasToKeepUp) {
Review comment:
Instead of number, can you put the explanation on what this variable means?
It looks like we need to choose one of 1-4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
