siddharthteotia commented on a change in pull request #4446: Add support in the
rebalancer for the user to provide minimum number of serving replicas
URL: https://github.com/apache/incubator-pinot/pull/4446#discussion_r307190201
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/TableRebalancer.java
##########
@@ -162,10 +164,12 @@ public RebalanceResult rebalance(TableConfig
tableConfig, RebalanceSegmentStrate
if (zkBaseDataAccessor
.set(idealStateKey.getPath(), nextIdealState.getRecord(),
currentIdealState.getRecord().getVersion(),
AccessOption.PERSISTENT)) {
+ LOGGER.debug("Successfully persisted the ideal state in ZK. Will
wait for External view to converge");
// if we succeeded, wait for the change to stabilize
waitForStable(tableNameWithType);
// clear retries as it tracks failures with each idealstate update
attempt
retries = 0;
+ LOGGER.debug("External view converged for the change in ideal state.
Will start the next iteration now");
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
