siddharthteotia commented on a change in pull request #4446: Add support in the
rebalancer for the user to provide minimum number of serving replicas
URL: https://github.com/apache/incubator-pinot/pull/4446#discussion_r308431194
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/TableRebalancer.java
##########
@@ -257,47 +390,162 @@ private void setTargetState(IdealState idealState,
String segmentId, Map<String,
}
/**
- * Check if IdealState = ExternalView. If its not equal, return the number
of differing segments.
+ * Check if external view has converged to ideal state
+ * @param tableName name of table that we are rebalancing
+ * @return true if external view is same as ideal state, false otherwise
*/
- public int isStable(String tableName) {
+ private boolean isStable(String tableName) {
Review comment:
Done in the same PR -- keeping track of the number of segments not converged
and then printing a log message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
