snleee commented on a change in pull request #4464: Delete extra refreshed
segments after segment push
URL: https://github.com/apache/incubator-pinot/pull/4464#discussion_r308486855
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentTarPushJob.java
##########
@@ -39,6 +45,7 @@ public SegmentTarPushJob(Properties properties) {
int port =
Integer.parseInt(properties.getProperty(JobConfigConstants.PUSH_TO_PORT));
_pushLocations = PushLocation.getPushLocations(hosts, port);
_rawTableName =
Preconditions.checkNotNull(_properties.getProperty(JobConfigConstants.SEGMENT_TABLE_NAME));
+ _deleteExtraSegments =
Boolean.parseBoolean(properties.getProperty(JobConfigConstants.IS_DELETE_EXTRA_SEGMENTS,
"false"));
Review comment:
`DELETE_EXTRA_SEGMENTS` seems to be good enough :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
