siddharthteotia commented on issue #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas URL: https://github.com/apache/incubator-pinot/pull/4446#issuecomment-516644458 Addressed review comments. Added integration tests for realtime LLC (consuming, without consuming), realtime HLC and segment movement stats. @snleee brought up a point w.r.t throwing exception on detecting ERROR state in external view. Currently we throw exception on detecting error in external view. What are the pros and cons of ignoring it and continuing with the hope that probably there is 1 of many segments that is in ERROR state and may be we can continue with rebalancing v/s the current approach of aborting the rebalancer midway by throwing exception.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
