Jackie-Jiang commented on a change in pull request #4455: Fix num entries
scanned in filter for MultiValue scanner
URL: https://github.com/apache/incubator-pinot/pull/4455#discussion_r309009312
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/MVScanDocIdIterator.java
##########
@@ -80,9 +81,11 @@ public boolean isMatch(int docId) {
return false;
}
valueIterator.skipTo(docId);
- _numEntriesScanned++;
int length = valueIterator.nextIntVal(intArray);
- return evaluator.applyMV(intArray, length);
+ MutableInt numEntriesScannedInEvaluator = new MutableInt(0);
+ boolean ret = evaluator.applyMV(intArray, length,
numEntriesScannedInEvaluator);
+ _numEntriesScanned += numEntriesScannedInEvaluator.toInteger();
Review comment:
You can make _numEntriesScanned a MutableInt and keep passing it to the
evaluators. In the getNumEntriesScanned(), return _numEntriesScanned.intValue()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
