[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #4483: [TE] frontend - harleyjj/create-alert - add link for onboarding mysql…

[GitBox]

harleyjj commented on a change in pull request #4483: [TE] frontend - 
harleyjj/create-alert - add link for onboarding mysql…
URL: https://github.com/apache/incubator-pinot/pull/4483#discussion_r309341629
 
 

 ##########
 File path: 
thirdeye/thirdeye-frontend/app/pods/components/detection-yaml/template.hbs
 ##########
 @@ -3,9 +3,10 @@
 </div>
 <div class="col-xs-12 {{if isEditMode "bottom-margin"}}">
   {{#unless isEditMode}}
-    <label for="select-metric" class="control-label te-label te-label--taller 
required">Can't find your metric?
+    <label for="select-metric" class="control-label te-label te-label--taller 
required">Can't find your metric? Import a Metric From
 
 Review comment:
   Here are some screenshots to show why the sentence looks split: 
   <img width="1139" alt="Screen Shot 2019-07-31 at 10 25 03 AM" 
src="https://user-images.githubusercontent.com/10106733/62233529-9e527a00-b37d-11e9-853b-910d4e930e5a.png";>
   <img width="457" alt="Screen Shot 2019-07-31 at 10 25 11 AM" 
src="https://user-images.githubusercontent.com/10106733/62233552-a90d0f00-b37d-11e9-9971-dadd665f3c7d.png";>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org