Jackie-Jiang commented on issue #4487: Fix the flakiness of PinotControllerModeTest by enabling the periodic rebalance URL: https://github.com/apache/incubator-pinot/pull/4487#issuecomment-517029409 > > > So the periodic rebalance will be enabled in the controller of controllerTest instead of a separated helixOnlyController, right? > > > > > > Periodic rebalance will be enabled when calling ControllerTest.startController() with Pinot-Ony or Dual mode. > > But in your PR you just pass the **helixOnly**ControllerConf to the test suite. How does that enable periodic rebalance? The first test does not require the periodic rebalance. I changed it just for consistency.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
