mcvsubbu commented on a change in pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas URL: https://github.com/apache/incubator-pinot/pull/4446#discussion_r309511480
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/TableRebalancer.java ########## @@ -67,15 +72,18 @@ private static final int MAX_RETRIES = 10; private static final int EXTERNAL_VIEW_CHECK_INTERVAL_MS = 30000; + private static final int EXTERNVAL_VIEW_STABILIZATON_MAX_WAIT_MS = 300000; Review comment: Declare this in minutes, and then comnvert it to millis when you want to use it. That way, you can use the same value in log messages as well. Also, the max wait time should depend on the amount of moves we need to do. Hosts may need to download segments (which can be serialized). We do not limit the number of segment moves into a target host in any way. For a host to download a segment and load it into memory could take a while if the number if segments to be downloaded in a target host is large. I am fine if you set it to some large value now (in the interest of getting this PR in) and the refine it next time around. Also, the wait time can be taken from command line to alleviate the problem somewhat. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
