codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=h1) Report > Merging [#4323](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/dfdf443b393ce7c73e53cc86d9a1212194a41416?src=pr&el=desc) will **increase** coverage by `20.87%`. > The diff coverage is `86.97%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4323 +/- ## ============================================ + Coverage 44.82% 65.7% +20.87% - Complexity 0 20 +20 ============================================ Files 1062 1063 +1 Lines 55374 55471 +97 Branches 8061 8066 +5 ============================================ + Hits 24821 36446 +11625 + Misses 28421 16388 -12033 - Partials 2132 2637 +505 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../pinot/controller/api/upload/SegmentValidator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1NlZ21lbnRWYWxpZGF0b3IuamF2YQ==) | `64.7% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...t/core/data/partition/MurmurPartitionFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3BhcnRpdGlvbi9NdXJtdXJQYXJ0aXRpb25GdW5jdGlvbi5qYXZh) | `77.77% <100%> (-2.87%)` | `0 <0> (ø)` | | | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `79.16% <100%> (+48.61%)` | `0 <0> (ø)` | :arrow_down: | | [...anager/realtime/SegmentBuildTimeLeaseExtender.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU2VnbWVudEJ1aWxkVGltZUxlYXNlRXh0ZW5kZXIuamF2YQ==) | `57.4% <100%> (+3.7%)` | `0 <0> (ø)` | :arrow_down: | | [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `83.6% <100%> (+14.75%)` | `0 <0> (ø)` | :arrow_down: | | [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `70.87% <100%> (+15.88%)` | `0 <0> (ø)` | :arrow_down: | | [...n/java/org/apache/pinot/common/utils/HashUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvSGFzaFV0aWwuamF2YQ==) | `43.1% <100%> (+37.38%)` | `0 <0> (ø)` | :arrow_down: | | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `81.25% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9QaW5vdFRhc2tNYW5hZ2VyLmphdmE=) | `92.45% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `82.41% <100%> (+64.83%)` | `0 <0> (ø)` | :arrow_down: | | ... and [582 more](https://codecov.io/gh/apache/incubator-pinot/pull/4323/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=footer). Last update [dfdf443...dfb1bd4](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
