Jackie-Jiang commented on a change in pull request #4500: Add file-evening to 
hadoop pre-process
URL: https://github.com/apache/incubator-pinot/pull/4500#discussion_r311793767
 
 

 ##########
 File path: 
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java
 ##########
 @@ -446,6 +480,21 @@ private Schema getSchema(Path inputPathDir)
     return avroSchema;
   }
 
+  private long countAvroRecords(List<Path> inputPaths) throws IOException {
+    long count = 0;
+
+    for (Path path : inputPaths) {
+      DataFileStream<GenericRecord> dataFileStream = getAvroReader(path);
 
 Review comment:
   We need to scan all the files to get the record count? That will be super 
expensive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to