fx19880617 commented on a change in pull request #4475: Add sql +, -, *, /
symbol arith
URL: https://github.com/apache/incubator-pinot/pull/4475#discussion_r312689854
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -49,6 +49,17 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(CalciteSqlParser.class);
+ private static final Map<String, String> FUNC_NAME_MAP;
+
+ // Calcite Sqlkind name to pinot operator name map
+ static {
+ FUNC_NAME_MAP = new HashMap<String, String>();
Review comment:
Could you rename this to `CALCITE_TO_PINOT_FUNC_NAME_MAP`. Also it's better
to make this an immutable map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
