kishoreg commented on a change in pull request #4517: Adding config to use let
controller/broker/server to set hostname
URL: https://github.com/apache/incubator-pinot/pull/4517#discussion_r312708036
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -107,7 +108,9 @@ public HelixBrokerStarter(Configuration brokerConf, String
clusterName, String z
_zkServers = zkServer.replaceAll("\\s+", "");
if (brokerHost == null) {
- brokerHost = NetUtil.getHostAddress();
+ brokerHost =
+
_brokerConf.getBoolean(CommonConstants.Helix.PREFER_HOSTNAME_IN_DEFAULT_INSTANCD_ID_KEY,
false) ? NetUtil
Review comment:
Typo Instance can we shorten the constant. SET_INSTANCEID_TO_HOSTNAME
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
