fx19880617 commented on a change in pull request #4517: Adding config to use let controller/broker/server to set hostname URL: https://github.com/apache/incubator-pinot/pull/4517#discussion_r312712779
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java ########## @@ -107,7 +108,9 @@ public HelixBrokerStarter(Configuration brokerConf, String clusterName, String z _zkServers = zkServer.replaceAll("\\s+", ""); if (brokerHost == null) { - brokerHost = NetUtil.getHostAddress(); + brokerHost = + _brokerConf.getBoolean(CommonConstants.Helix.PREFER_HOSTNAME_IN_DEFAULT_INSTANCD_ID_KEY, false) ? NetUtil Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org