snleee commented on a change in pull request #4522: [Instance Assignment] Enhance Instance class to include the pool config URL: https://github.com/apache/incubator-pinot/pull/4522#discussion_r313163542
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/pojos/Instance.java ########## @@ -19,119 +19,127 @@ package org.apache.pinot.controller.api.pojos; Review comment: If possible, can we move this class to another package? I think that this should be under `pinot-common`? For instance, `Tenant` which is a similar concept is placed in `pinot-common/.../config` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
