codecov-io commented on issue #4522: [Instance Assignment] Enhance Instance class to include the pool config URL: https://github.com/apache/incubator-pinot/pull/4522#issuecomment-520642941 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=h1) Report > Merging [#4522](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/115cab9649378dcbd6afffafcfa5b0bbca8c24f7?src=pr&el=desc) will **decrease** coverage by `0.09%`. > The diff coverage is `75.32%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4522 +/- ## =========================================== - Coverage 64.71% 64.62% -0.1% Complexity 20 20 =========================================== Files 1073 1073 Lines 55725 55710 -15 Branches 8119 8116 -3 =========================================== - Hits 36064 36001 -63 - Misses 17006 17061 +55 + Partials 2655 2648 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/assignment/instance/InstanceTagPoolSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VUYWdQb29sU2VsZWN0b3IuamF2YQ==) | `94.54% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/pinot/minion/MinionStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vTWluaW9uU3RhcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...lix/core/minion/PinotHelixTaskResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9QaW5vdEhlbGl4VGFza1Jlc291cmNlTWFuYWdlci5qYXZh) | `4.65% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...er/api/resources/PinotInstanceRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90SW5zdGFuY2VSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `65.95% <100%> (+0.74%)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `42.3% <100%> (+3.84%)` | `0 <0> (ø)` | :arrow_down: | | [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `83.11% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../java/org/apache/pinot/common/config/Instance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0luc3RhbmNlLmphdmE=) | `76.31% <76.31%> (ø)` | `0 <0> (?)` | | | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `62.43% <85.71%> (-0.15%)` | `0 <0> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `32.05% <0%> (-52.57%)` | `0% <0%> (ø)` | | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `41.09% <0%> (-34.25%)` | `0% <0%> (ø)` | | | ... and [27 more](https://codecov.io/gh/apache/incubator-pinot/pull/4522/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=footer). Last update [115cab9...822a201](https://codecov.io/gh/apache/incubator-pinot/pull/4522?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
