codecov-io commented on issue #4516: [Instance Assignment] Plug in instance assignment URL: https://github.com/apache/incubator-pinot/pull/4516#issuecomment-520691213 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=h1) Report > Merging [#4516](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1d7b4a5763771f93b9abf25fef25aab7c83e4268?src=pr&el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `73.66%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4516 +/- ## ============================================ - Coverage 64.72% 64.67% -0.06% Complexity 20 20 ============================================ Files 1073 1074 +1 Lines 55710 55858 +148 Branches 8116 8148 +32 ============================================ + Hits 36061 36127 +66 - Misses 16996 17075 +79 - Partials 2653 2656 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/org/apache/pinot/core/util/ReplicationUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1JlcGxpY2F0aW9uVXRpbHMuamF2YQ==) | `90.9% <ø> (+11.96%)` | `0 <0> (ø)` | :arrow_down: | | [...ent/instance/InstanceReplicaPartitionSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VSZXBsaWNhUGFydGl0aW9uU2VsZWN0b3IuamF2YQ==) | `97.8% <ø> (-0.03%)` | `0 <0> (ø)` | | | [...ache/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvWktNZXRhZGF0YVByb3ZpZGVyLmphdmE=) | `67.41% <ø> (-1.82%)` | `0 <0> (ø)` | | | [.../assignment/instance/InstanceAssignmentDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VBc3NpZ25tZW50RHJpdmVyLmphdmE=) | `96.29% <100%> (+0.46%)` | `0 <0> (ø)` | :arrow_down: | | [...ller/helix/core/assignment/InstancePartitions.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvSW5zdGFuY2VQYXJ0aXRpb25zLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...helix/core/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvSW5zdGFuY2VQYXJ0aXRpb25zVXRpbHMuamF2YQ==) | `38.23% <47.61%> (+8.23%)` | `0 <0> (ø)` | :arrow_down: | | [...ources/PinotInstanceAssignmentRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90SW5zdGFuY2VBc3NpZ25tZW50UmVzdGxldFJlc291cmNlLmphdmE=) | `67.2% <67.2%> (ø)` | `0 <0> (?)` | | | [.../controller/helix/ControllerRequestURLBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9Db250cm9sbGVyUmVxdWVzdFVSTEJ1aWxkZXIuamF2YQ==) | `83.87% <76.92%> (-1.85%)` | `0 <0> (ø)` | | | [...config/instance/InstanceAssignmentConfigUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZ1V0aWxzLmphdmE=) | `78.94% <80%> (+3.94%)` | `0 <0> (ø)` | :arrow_down: | | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `62.92% <92.59%> (+0.48%)` | `0 <0> (ø)` | :arrow_down: | | ... and [39 more](https://codecov.io/gh/apache/incubator-pinot/pull/4516/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=footer). Last update [1d7b4a5...1141058](https://codecov.io/gh/apache/incubator-pinot/pull/4516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
