npawar commented on a change in pull request #4527: Group by with order by
URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314382962
 
 

 ##########
 File path: 
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java
 ##########
 @@ -64,7 +64,7 @@
 
   private SelectionResults _selectionResults;
   private List<AggregationResult> _aggregationResults;
-  private GroupByOrderByResults _groupByOrderByResults;
+  private OrderedGroupByResults _orderedGroupByResults;
 
 Review comment:
   There's 2 options in the existing structure:
   1. Selection results - this has only selection columns
   2. List<AggregationResult> - these are split up as group by columns + 1 
aggregation, per aggregation
   
   Potentially we can get rid of List<AggregationResult> when we completely 
remove the existing group by behavior

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to