Jackie-Jiang commented on a change in pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment URL: https://github.com/apache/incubator-pinot/pull/4533#discussion_r314889280
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignment.java ########## @@ -23,37 +23,42 @@ import org.apache.commons.configuration.Configuration; import org.apache.helix.HelixManager; import org.apache.pinot.common.config.TableConfig; +import org.apache.pinot.common.utils.InstancePartitionsType; +import org.apache.pinot.controller.helix.core.assignment.InstancePartitions; /** - * Strategy to assign segment to instances or rebalance all segments in a table. + * Interface for segment assignment and table rebalancing. Review comment: This is not the same interface as the one we mentioned in the documentation, but the new added one for the resource assignment feature. We will deprecate the old interface once the new feature is done, and I will add documentation for the new assignment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org