xiaohui-sun commented on a change in pull request #4554: [TE] Add timeout for
all tasks and clean up RUNNING states if timeout
URL: https://github.com/apache/incubator-pinot/pull/4554#discussion_r317256900
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/monitor/MonitorTaskRunner.java
##########
@@ -64,9 +64,19 @@
private void executeMonitorUpdate(MonitorTaskInfo monitorTaskInfo) {
LOG.info("Execute monitor update {}", monitorTaskInfo);
+ int jobRetentionDays = monitorTaskInfo.getDefaultRetentionDays();
try {
+ // Mark expired task as TIMEOUT
Review comment:
Add more info why we add this.
Also I remember we want to clean up the RUNNING tasks when worker starts. Is
that fix already in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
