Jackie-Jiang commented on a change in pull request #4561: Add metric on Helix
and Pinot controller leadership
URL: https://github.com/apache/incubator-pinot/pull/4561#discussion_r317376569
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java
##########
@@ -48,6 +48,12 @@
// Pinot controller leader
PINOT_CONTROLLER_LEADER("PinotControllerLeader", true),
+ // Pinot controller partition leader
+ PINOT_CONTROLLER_PARTITION_LEADER("PinotControllerPartitionLeader", true),
+
+ // Pinot controller resource enabled
+ PINOT_LEAD_CONTROLLER_ENABLED("PinotLeadControllerEnabled", true),
Review comment:
`PINOT_LEAD_CONTROLLER_RESOURCE_ENABLED("PinotLeadControllerResourceEnabled",
true)` for clarity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
