codecov-io commented on issue #4562: Handle the virtual column logic in FieldSpec instead of Schema URL: https://github.com/apache/incubator-pinot/pull/4562#issuecomment-524590677 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=h1) Report > Merging [#4562](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9b5775e79c8881d06b2ed472698eabbff56317d6?src=pr&el=desc) will **decrease** coverage by `12.91%`. > The diff coverage is `79.71%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4562 +/- ## ============================================= - Coverage 56.2% 43.28% -12.92% ============================================= Files 1064 1064 Lines 55338 55329 -9 Branches 8068 8066 -2 ============================================= - Hits 31101 23948 -7153 - Misses 21761 29255 +7494 + Partials 2476 2126 -350 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/pinot/common/data/FieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9GaWVsZFNwZWMuamF2YQ==) | `55.76% <0%> (-19.72%)` | `0 <0> (ø)` | | | [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `92.15% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...main/java/org/apache/pinot/common/data/Schema.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9TY2hlbWEuamF2YQ==) | `38.15% <100%> (-42.37%)` | `0 <0> (ø)` | | | [...e/indexsegment/immutable/ImmutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRJbXBsLmphdmE=) | `56.89% <16.66%> (-9.78%)` | `0 <0> (ø)` | | | [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `63.77% <50%> (-12.88%)` | `0 <0> (ø)` | | | [...nt/virtualcolumn/VirtualColumnProviderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtblByb3ZpZGVyRmFjdG9yeS5qYXZh) | `72.72% <50%> (-4.2%)` | `0 <0> (ø)` | | | [...indexsegment/generator/SegmentGeneratorConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvZ2VuZXJhdG9yL1NlZ21lbnRHZW5lcmF0b3JDb25maWcuamF2YQ==) | `52.9% <75%> (+0.96%)` | `0 <0> (ø)` | :arrow_down: | | [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `79.83% <85.71%> (-9.06%)` | `0 <0> (ø)` | | | [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `69.15% <89.74%> (+4.36%)` | `0 <0> (ø)` | :arrow_down: | | [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | ... and [715 more](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=footer). Last update [9b5775e...d092879](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
