Jackie-Jiang commented on a change in pull request #4562: Handle the virtual
column logic in FieldSpec instead of Schema
URL: https://github.com/apache/incubator-pinot/pull/4562#discussion_r317418361
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
##########
@@ -153,6 +154,11 @@ public void setVirtualColumnProvider(String
virtualColumnProvider) {
_virtualColumnProvider = virtualColumnProvider;
}
+ @JsonIgnore
+ public boolean isVirtualColumn() {
+ return _virtualColumnProvider != null && !_virtualColumnProvider.isEmpty();
Review comment:
Virtual column works only when the provider is provided. Added comments
about that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
