codecov-io edited a comment on issue #4562: Handle the virtual column logic in FieldSpec instead of Schema URL: https://github.com/apache/incubator-pinot/pull/4562#issuecomment-524590677 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=h1) Report > Merging [#4562](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/38c73aa1c8d146fc1f344cb90a10a884b8734d6b?src=pr&el=desc) will **increase** coverage by `21.27%`. > The diff coverage is `85.91%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4562 +/- ## ============================================= + Coverage 43.26% 64.53% +21.27% - Complexity 0 20 +20 ============================================= Files 1064 1064 Lines 55351 55340 -11 Branches 8068 8065 -3 ============================================= + Hits 23949 35716 +11767 + Misses 29285 16984 -12301 - Partials 2117 2640 +523 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/pinot/common/data/FieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9GaWVsZFNwZWMuamF2YQ==) | `76.28% <0%> (+20.15%)` | `0 <0> (ø)` | :arrow_down: | | [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `92.15% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...main/java/org/apache/pinot/common/data/Schema.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9TY2hlbWEuamF2YQ==) | `81.14% <100%> (+42.61%)` | `0 <0> (ø)` | :arrow_down: | | [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `82.75% <100%> (+13.59%)` | `0 <0> (ø)` | :arrow_down: | | [...e/indexsegment/immutable/ImmutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRJbXBsLmphdmE=) | `62.06% <16.66%> (-1.43%)` | `0 <0> (ø)` | | | [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `77.24% <50%> (+13.47%)` | `0 <0> (ø)` | :arrow_down: | | [...nt/virtualcolumn/VirtualColumnProviderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtblByb3ZpZGVyRmFjdG9yeS5qYXZh) | `72.72% <50%> (-4.2%)` | `0 <0> (ø)` | | | [...indexsegment/generator/SegmentGeneratorConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvZ2VuZXJhdG9yL1NlZ21lbnRHZW5lcmF0b3JDb25maWcuamF2YQ==) | `62.25% <75%> (+9.35%)` | `0 <0> (ø)` | :arrow_down: | | [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `89.71% <85.71%> (+9.87%)` | `0 <0> (ø)` | :arrow_down: | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `82.6% <0%> (-4.35%)` | `0% <0%> (ø)` | | | ... and [569 more](https://codecov.io/gh/apache/incubator-pinot/pull/4562/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=footer). Last update [38c73aa...bbabdf6](https://codecov.io/gh/apache/incubator-pinot/pull/4562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
