codecov-io edited a comment on issue #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#issuecomment-524232323 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=h1) Report > Merging [#4553](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/cf9974c3fb418e33a020d547824a31b454f1ff91?src=pr&el=desc) will **increase** coverage by `8.32%`. > The diff coverage is `86.27%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4553 +/- ## ============================================ + Coverage 56.15% 64.47% +8.32% Complexity 20 20 ============================================ Files 1064 1070 +6 Lines 55318 55610 +292 Branches 8063 8113 +50 ============================================ + Hits 31062 35854 +4792 + Misses 21778 17112 -4666 - Partials 2478 2644 +166 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pinot/server/realtime/ControllerLeaderLocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL3JlYWx0aW1lL0NvbnRyb2xsZXJMZWFkZXJMb2NhdG9yLmphdmE=) | `91.42% <86.27%> (+2.41%)` | `0 <0> (ø)` | :arrow_down: | | [...e/indexsegment/immutable/ImmutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRJbXBsLmphdmE=) | `62.06% <0%> (-6.79%)` | `0% <0%> (ø)` | | | [...nt/virtualcolumn/VirtualColumnProviderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtblByb3ZpZGVyRmFjdG9yeS5qYXZh) | `72.72% <0%> (-4.2%)` | `0% <0%> (ø)` | | | [...nsport/netty/PooledNettyClientResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvUG9vbGVkTmV0dHlDbGllbnRSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `85.41% <0%> (-4.17%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `83.92% <0%> (-0.6%)` | `0% <0%> (ø)` | | | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9QaW5vdFRhc2tNYW5hZ2VyLmphdmE=) | `13.2% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `100% <0%> (ø)` | `0% <0%> (?)` | | | [...ain/java/org/apache/pinot/core/data/table/Key.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0tleS5qYXZh) | `50% <0%> (ø)` | `0% <0%> (?)` | | | [.../pinot/core/data/table/ConcurrentIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0NvbmN1cnJlbnRJbmRleGVkVGFibGUuamF2YQ==) | `95.45% <0%> (ø)` | `0% <0%> (?)` | | | [...ache/pinot/core/data/table/SimpleIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1NpbXBsZUluZGV4ZWRUYWJsZS5qYXZh) | `94.44% <0%> (ø)` | `0% <0%> (?)` | | | ... and [293 more](https://codecov.io/gh/apache/incubator-pinot/pull/4553/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=footer). Last update [cf9974c...0bb0345](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
