Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r319705294
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformBlockDataFetcher.java
##########
@@ -49,7 +49,32 @@ public TransformBlockDataFetcher(BlockValSet[]
blockValSets, Dictionary[] dictio
return row;
}
- Fetcher createFetcher(BlockValSet blockValSet,
+ /**
+ * Create SV non-dictionary based fetcher
+ * @param blockValSet column value set
+ * @return fetcher
+ */
+ private Fetcher createSVNoDictionaryFetcher(BlockValSet blockValSet) {
+ switch (blockValSet.getValueType()) {
+ case INT:
+ return new SVIntValueFetcher(blockValSet.getIntValuesSV());
+ case LONG:
+ return new SVLongValueFetcher(blockValSet.getLongValuesSV());
+ case FLOAT:
+ return new SVFloatValueFetcher(blockValSet.getFloatValuesSV());
+ case DOUBLE:
+ return new SVDoubleValueFetcher(blockValSet.getDoubleValuesSV());
+ case BOOLEAN:
Review comment:
BOOLEAN should not appear in this level. Internally we don't have BOOLEAN
type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
