siddharthteotia commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320621606
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionUtils.java
##########
@@ -89,12 +104,16 @@ public static AggregationFunctionContext
getAggregationFunctionContext(@Nonnull
}
@Nonnull
- public static AggregationFunction[] getAggregationFunctions(@Nonnull
List<AggregationInfo> aggregationInfos) {
+ public static AggregationFunction[] getAggregationFunctions(BrokerRequest
brokerRequest) {
+ List<AggregationInfo> aggregationInfos =
brokerRequest.getAggregationsInfo();
int numAggregationFunctions = aggregationInfos.size();
AggregationFunction[] aggregationFunctions = new
AggregationFunction[numAggregationFunctions];
for (int i = 0; i < numAggregationFunctions; i++) {
+ AggregationInfo aggregationInfo = aggregationInfos.get(i);
Review comment:
Thanks. Had forgotten earlier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
