kishoreg commented on a change in pull request #4583: Support default value for
Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r320994213
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -303,6 +304,10 @@ protected void createColumnV1Indices(String column)
dictionaryElementSize =
StringUtil.encodeUtf8(stringDefaultValue).length;
Review comment:
we should use something that is independent of the encoding on the system.
The file might be created/saved in a different encoding right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
