Jackie-Jiang commented on a change in pull request #4591: Deleting preprocess
output post segment creation
URL: https://github.com/apache/incubator-pinot/pull/4591#discussion_r321852321
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
##########
@@ -90,6 +91,11 @@ public SegmentCreationJob(Properties properties) {
_pushLocations = null;
}
+ String preprocessOutputPath =
_properties.getProperty(JobConfigConstants.PREPROCESS_PATH_TO_OUTPUT);
Review comment:
SegmentCreationJob should have no concept on the pre-process path. Also,
client might want to keep the pre-process output files, so we should not always
delete them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
