cyy0714 commented on a change in pull request #4600: [TE] frontend -
harleyjj/ai - fix small bug in AI Availability
URL: https://github.com/apache/incubator-pinot/pull/4600#discussion_r322468442
##########
File path: thirdeye/thirdeye-frontend/app/pods/aiavailability/route.js
##########
@@ -93,13 +93,13 @@ export default Route.extend({
anomaliesArray.forEach(anomalyId => {
const row = flow;
row['link to RCA'] = anomalyId;
- row.comment = row.comment.anomalyId;
+ row.comment = row.comment[anomalyId];
// build array of strings to put on DOM
row.columns = [];
tableHeaders.forEach(header => {
const cellValue = row[header.text];
if (header.text === 'link to RCA') {
- const domString = `<a
href="https://thirdeye.corp.linkedin.com/app/#/rootcause?anomalyId=${cellValue}";>Comment
of the anomaly</a>`;
+ const domString = `<a
href="https://thirdeye.corp.linkedin.com/app/#/rootcause?anomalyId=${cellValue}";>Investigate
anomaly</a>`;
Review comment:
I will suggest to link the RCA link to the comment text. In case there are
multiple anomalies under the same row, it is easier to distinguish the
different anomaly on different days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
