xiaohui-sun commented on a change in pull request #4601: [TE] Exclude
template/blacklist emails before sending out alert
URL: https://github.com/apache/incubator-pinot/pull/4601#discussion_r322499013
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionEmailAlerter.java
##########
@@ -106,6 +116,16 @@ private void
whitelistRecipients(DetectionAlertFilterRecipients recipients) {
}
}
+ private void blacklistRecipients(DetectionAlertFilterRecipients recipients) {
+ if (recipients != null) {
Review comment:
Combine two ifs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
