mcvsubbu commented on a change in pull request #4597: [WIP] Adding json_path function to extract field from json object URL: https://github.com/apache/incubator-pinot/pull/4597#discussion_r322853507
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonPathTransformFunction.java ########## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.transform.function; + +import com.jayway.jsonpath.JsonPath; +import java.math.BigDecimal; +import java.util.List; +import java.util.Map; +import javax.annotation.Nonnull; +import org.apache.pinot.common.data.FieldSpec; +import org.apache.pinot.core.common.DataSource; +import org.apache.pinot.core.operator.blocks.ProjectionBlock; +import org.apache.pinot.core.operator.transform.TransformResultMetadata; + + +/** + * json_path(jsonFieldName, 'json_path', 'results_type') + */ +public class JsonPathTransformFunction extends BaseTransformFunction { + + public static final String FUNCTION_NAME = "json_path"; + + private TransformFunction _jsonFieldTransformFunction; + private String _jsonPath; + private String _resultsType; + private TransformResultMetadata _resultMetadata; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + public void init(@Nonnull List<TransformFunction> arguments, @Nonnull Map<String, DataSource> dataSourceMap) { + // Check that there are exactly 2 arguments + if (arguments.size() != 3) { + throw new IllegalArgumentException( + "Exactly 3 arguments are required for transform function: JSON_PATH(jsonFieldName, 'json_path', 'results_type')"); + } + + TransformFunction firstArgument = arguments.get(0); + if (firstArgument instanceof LiteralTransformFunction || !firstArgument.getResultMetadata().isSingleValue()) { + throw new IllegalArgumentException( + "The first argument of TIME_CONVERT transform function must be a single-valued column or a transform function"); Review comment: TIME_CONVERT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
