jackjlli commented on a change in pull request #4545: Add APIs to get leader
for all tables or a given table
URL: https://github.com/apache/incubator-pinot/pull/4545#discussion_r322898170
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##########
@@ -214,6 +191,9 @@ private boolean isLeadControllerResourceEnabled() {
* @param instanceId instance id without any prefix, e.g. localhost_9000
* */
private Pair<String, Integer> convertToHostAndPortPair(String instanceId) {
+ if (instanceId == null) {
Review comment:
TODO added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
