codecov-io commented on issue #4602: First pass of GROUP BY with ORDER BY 
support
URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=h1) 
Report
   > Merging 
[#4602](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/dbcbd2eae2430050c003de86c605a7ed8f0e1b9e?src=pr&el=desc)
 will **decrease** coverage by `7.67%`.
   > The diff coverage is `77.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/4602/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4602      +/-   ##
   ============================================
   - Coverage     64.23%   56.55%   -7.68%     
     Complexity       32       32              
   ============================================
     Files          1072     1074       +2     
     Lines         55702    56025     +323     
     Branches       8131     8184      +53     
   ============================================
   - Hits          35778    31687    -4091     
   - Misses        17276    21833    +4557     
   + Partials       2648     2505     -143
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
 | `34.61% <ø> (-7.7%)` | `0 <0> (ø)` | |
   | 
[...e/query/aggregation/groupby/GroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0dyb3VwS2V5R2VuZXJhdG9yLmphdmE=)
 | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...ava/org/apache/pinot/pql/parsers/Pql2Compiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QcWwyQ29tcGlsZXIuamF2YQ==)
 | `64.88% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...ain/java/org/apache/pinot/core/data/table/Key.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0tleS5qYXZh)
 | `87.5% <0%> (+37.5%)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh)
 | `85.71% <0%> (-14.29%)` | `0 <0> (ø)` | |
   | 
[...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=)
 | `9.67% <0%> (-67.83%)` | `0 <0> (ø)` | |
   | 
[...apache/pinot/core/query/reduce/CombineService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQ29tYmluZVNlcnZpY2UuamF2YQ==)
 | `25% <0%> (-36.54%)` | `0 <0> (ø)` | |
   | 
[...ion/groupby/AggregationGroupByTrimmingService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0FnZ3JlZ2F0aW9uR3JvdXBCeVRyaW1taW5nU2VydmljZS5qYXZh)
 | `92.85% <100%> (-1.59%)` | `0 <0> (ø)` | |
   | 
[...t/common/response/broker/BrokerResponseNative.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL0Jyb2tlclJlc3BvbnNlTmF0aXZlLmphdmE=)
 | `87.36% <100%> (-3.94%)` | `0 <0> (ø)` | |
   | 
[...tion/groupby/DictionaryBasedGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RpY3Rpb25hcnlCYXNlZEdyb3VwS2V5R2VuZXJhdG9yLmphdmE=)
 | `96.84% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [301 
more](https://codecov.io/gh/apache/incubator-pinot/pull/4602/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=footer).
 Last update 
[dbcbd2e...334bceb](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to