noob-se7en commented on code in PR #14811:
URL: https://github.com/apache/pinot/pull/14811#discussion_r1936968482
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -169,19 +169,40 @@ public Map<String, String> forceCommit(
@ApiParam(value = "Comma separated list of partition group IDs to be
committed") @QueryParam("partitions")
String partitionGroupIds,
@ApiParam(value = "Comma separated list of consuming segments to be
committed") @QueryParam("segments")
- String consumingSegments, @Context HttpHeaders headers) {
+ String consumingSegments,
+ @ApiParam(value = "Max number of consuming segments to commit at once
(default = Integer.MAX_VALUE)")
+ @QueryParam("batchSize")
+ Integer batchSize,
Review Comment:
We can only put compile-time constant here, hence this won't work.
Refactoring to change 0 to max
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -169,19 +169,40 @@ public Map<String, String> forceCommit(
@ApiParam(value = "Comma separated list of partition group IDs to be
committed") @QueryParam("partitions")
String partitionGroupIds,
@ApiParam(value = "Comma separated list of consuming segments to be
committed") @QueryParam("segments")
- String consumingSegments, @Context HttpHeaders headers) {
+ String consumingSegments,
+ @ApiParam(value = "Max number of consuming segments to commit at once
(default = Integer.MAX_VALUE)")
+ @QueryParam("batchSize")
+ Integer batchSize,
Review Comment:
We can only put compile-time constant here, hence this won't work.
Refactoring to change 0 to max instead of throwing exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
