akshayrai commented on a change in pull request #4611: [TE] Remove the logic of
reading stderr from phantomjs to avoid zombie processes
URL: https://github.com/apache/incubator-pinot/pull/4611#discussion_r324279730
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/alert/util/AlertScreenshotHelper.java
##########
@@ -70,25 +67,9 @@ private static String takeScreenshot(String anomalyId,
String dashboardHost, Str
LOG.info("imgPath {}", imgPath);
Process proc = Runtime.getRuntime().exec(new String[]{phantomJsPath,
"phantomjs", "--ssl-protocol=any", "--ignore-ssl-errors=true",
phantomScript, imgRoute, imgPath});
-
- StringBuilder sbError = new StringBuilder();
Review comment:
Can there be any side-effects of removing this logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
