itschrispeck commented on code in PR #15010:
URL: https://github.com/apache/pinot/pull/15010#discussion_r1951851458
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -1254,6 +1254,25 @@ public int downloadFile(URI uri, File dest, AuthProvider
authProvider, List<Head
return _httpClient.downloadFile(uri, HttpClient.DEFAULT_SOCKET_TIMEOUT_MS,
dest, authProvider, httpHeaders);
}
+ /**
+ * Download a file.
+ *
+ * @param uri URI
+ * @param dest File destination
+ * @param authProvider auth provider
+ * @param httpHeaders http headers
+ * @param connectionRequestTimeoutMs Connection request timeout in
milliseconds
+ * @param socketTimeoutMs Socket timeout in milliseconds
+ * @return Response status code
Review Comment:
Yep, the class javadoc mentions this class uses HTTP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
