npawar commented on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-531953246 > Looks good overall. Few places where we can optimize further but let us do a benchmark before optimizing further. > > I am assuming this code will only be triggered with query option =SQL That's right. The if check in CombinePlanNode for `is groupByMode SQL` and then the same check in `BrokerReduceService::reduceOnDataTable` will ensure this only kicks in when `groupByMode=sql` is set in the json payload
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
