mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324932788
########## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerLeaderLocatorIntegrationTest.java ########## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.integration.tests; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicReference; +import org.apache.helix.model.ExternalView; +import org.apache.helix.model.MasterSlaveSMD; +import org.apache.pinot.common.utils.CommonConstants.Helix; +import org.apache.pinot.common.utils.helix.LeadControllerUtils; +import org.apache.pinot.controller.ControllerConf; +import org.apache.pinot.controller.ControllerStarter; +import org.apache.pinot.controller.helix.ControllerTest; +import org.apache.pinot.pql.parsers.utils.Pair; +import org.apache.pinot.server.realtime.ControllerLeaderLocator; +import org.apache.pinot.util.TestUtils; +import org.testng.Assert; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + + +public class ControllerLeaderLocatorIntegrationTest extends ControllerTest { + private static long TIMEOUT_IN_MS = 1000_000L; + private HashMap<Integer, String> _partitionToTableMap; + + @BeforeClass + public void setUp() { + startZk(); + startController(); + + ControllerLeaderLocator.create(_helixManager); + + findTableNamesForAllPartitions(); + } + + @Test + public void testControllerLeaderLocator() { + String testTableName1 = "testTable"; + String testTableName2 = "testTable2"; + ControllerLeaderLocator controllerLeaderLocator = ControllerLeaderLocator.getInstance(); + + Pair<String, Integer> pair = controllerLeaderLocator.getControllerLeader(testTableName1); + // Before resource config is enabled, use helix leader + Assert.assertNotNull(pair); + Assert.assertEquals(pair.getFirst(), ControllerTest.LOCAL_HOST); + Assert.assertEquals((int) pair.getSecond(), ControllerTest.DEFAULT_CONTROLLER_PORT); + + // Enable lead controller resource + enableResourceConfigForLeadControllerResource(true); + + // Mock the behavior that 40 seconds have passed. + controllerLeaderLocator.setLastCacheInvalidateMillis(System.currentTimeMillis() - 40_000L); + controllerLeaderLocator.invalidateCachedControllerLeader(); + + // After resource config is enabled, use the lead controller in the resource + pair = controllerLeaderLocator.getControllerLeader(testTableName1); + Assert.assertNotNull(pair); + Assert.assertEquals(pair.getFirst(), ControllerTest.LOCAL_HOST); + Assert.assertEquals((int) pair.getSecond(), ControllerTest.DEFAULT_CONTROLLER_PORT); + + // Fetch the pair for test table 2, which should be the same as the 1st pair. + Pair<String, Integer> secondPair = controllerLeaderLocator.getControllerLeader(testTableName2); + Assert.assertNotNull(secondPair); + Assert.assertEquals(pair.getFirst(), secondPair.getFirst()); + Assert.assertEquals(pair.getSecond(), secondPair.getSecond()); + + ControllerConf secondControllerConfig = getDefaultControllerConfiguration(); + secondControllerConfig.setControllerPort(Integer.toString(DEFAULT_CONTROLLER_PORT + 1)); + ControllerStarter secondControllerStarter = new ControllerStarter(secondControllerConfig); + secondControllerStarter.start(); + + TestUtils + .waitForCondition(aVoid -> secondControllerStarter.getHelixResourceManager().getHelixZkManager().isConnected(), + TIMEOUT_IN_MS, "Failed to start the second controller"); + + Set<String> resultSet = new HashSet<>(); + TestUtils.waitForCondition(aVoid -> { + resultSet.clear(); + for (Map.Entry<Integer, String> entry : _partitionToTableMap.entrySet()) { + // Mock the behavior that 40 seconds have passed. + controllerLeaderLocator.setLastCacheInvalidateMillis(System.currentTimeMillis() - 40_000L); Review comment: you should not need this once you merge the other PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
