Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324931411
########## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ########## @@ -277,6 +281,36 @@ public HyperLogLog deserialize(ByteBuffer byteBuffer) { } }; + public static final ObjectSerDe<DistinctTable> DISTINCT_TABLE_SER_DE = new ObjectSerDe<DistinctTable>() { + + @Override + public byte[] serialize(DistinctTable distinctTable) { + try { + return distinctTable.toBytes(); + } catch (IOException e) { + throw new IllegalStateException("Caught exception while serializing DistinctHolder", e); Review comment: "Caught exception while serializing Distinct**Table**" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org