jadami10 commented on issue #15100: URL: https://github.com/apache/pinot/issues/15100#issuecomment-2674997780
> As an alternative, couldn't we emit metrics with an extra tag to indicate the phase we are in? We could, but I feel like there's some big downsides - Pinot's metrics framework is fairly messy for tags. It's not "pass in a list of tags". It's more like, "create a new function called emitServerMeterWtihPhaseTag". So I don't like adding to tags that don't exist - this feature logs and emits metrics every 10-30ms by default. At scale, this is actually quite expensive since you're paying for those logs and metrics either in storage costs or to some observability vendor - it wastes CPU time when the server is not actually serving queries/catching up. I don't see any need for "query killing" to be enabled before the server is even ready to serve queries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
