himanish-star commented on issue #14924:
URL: https://github.com/apache/pinot/issues/14924#issuecomment-2675168998
Hi @deemoliu @raghukn .... I can create a quick PR for this as I've gone
through the code.
So there are two solutions I believe:
1. Directly modify the current merge logic to always overwrite `prev column
value` with `new column value` even if the new value is `NULL`. This would not
require create a new merger.
```
if (!(merger instanceof OverwriteMerger)) {
Object prevValue = previousRow.getValue(column);
if (prevValue != null) {
resultHolder.put(column, merger.merge(prevValue,
newRow.getValue(column)));
}
}
2. Create a new merger named `ForceOverwriteMerger` and this will also need
the addition of a new strategy named `ForceOverwrite` and we can have the
separate handling for it.
Let me know which one to move forward with? I'm in the favor of `Approach 2`
so that `Overwrite` strategy remains intact and we introduce a new strategy and
merger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
