klsince commented on code in PR #15126:
URL: https://github.com/apache/pinot/pull/15126#discussion_r1970661505
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -252,26 +252,28 @@ public static class Instance {
// Preprocess throttle configs
public static final String CONFIG_OF_MAX_SEGMENT_PREPROCESS_PARALLELISM =
"pinot.server.max.segment.preprocess.parallelism";
- public static final String DEFAULT_MAX_SEGMENT_PREPROCESS_PARALLELISM =
String.valueOf(100);
+ public static final String DEFAULT_MAX_SEGMENT_PREPROCESS_PARALLELISM =
String.valueOf(Integer.MAX_VALUE);
Review Comment:
perhaps leave a comment that setting MAX here to disable the throttling
effectively
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/SegmentOperationsThrottlerTest.java:
##########
@@ -308,11 +308,13 @@ public void testServingQueriesDisabledWithAcquireRelease()
? Integer.parseInt(
CommonConstants.Helix.DEFAULT_MAX_SEGMENT_STARTREE_PREPROCESS_PARALLELISM_BEFORE_SERVING_QUERIES)
:
Integer.parseInt(CommonConstants.Helix.DEFAULT_MAX_SEGMENT_DOWNLOAD_PARALLELISM_BEFORE_SERVING_QUERIES);
+ // Default is too high: Integer.MAX_VALUE, take a large number of
permits to ensure we don't block
Review Comment:
nit: `..., take a limited number of permits so that the test doesn't take
too long to finish`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
