jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325333346
########## File path: pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java ########## @@ -68,45 +69,48 @@ public void testInvalidateCachedControllerLeader() { // Create Controller Leader Locator FakeControllerLeaderLocator.create(helixManager); - ControllerLeaderLocator controllerLeaderLocator = FakeControllerLeaderLocator.getInstance(); + FakeControllerLeaderLocator controllerLeaderLocator = FakeControllerLeaderLocator.getInstance(); // check values at startup - Assert.assertTrue(controllerLeaderLocator.isCachedControllerLeaderInvalid()); + Assert.assertFalse(controllerLeaderLocator.isCachedControllerLeaderValid()); Assert.assertEquals(controllerLeaderLocator.getLastCacheInvalidateMillis(), 0); // very first invalidate + long currentTimeMs = System.currentTimeMillis(); Review comment: `System.currentTimeMillis();` has been removed from the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org